Latest data point not plotted after a disconnect #2727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a disconnect is detected in the last message then the next() function never gets called to save the latest data point and so it does not get plotted.
|
Hi @shroffk, would you mind taking a look at this PR if you have a moment? |
shroffk
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue was introduced in #2713 where we attempted to show PV disconnections in the data browser. In the current implementation we attempt to detect a 'disconnect' messages in the metadata of a data item and add an extra data point to signal this. On the following
next()call to the iterator it uses the previous message (which was just replaced with the disconnect) to make sure no data is missed.It turns out there is a particular case that causes a problem when it is the final message from the archiver that contains the disconnect. What this means is that now the
next()function never gets called as the iterator is empty (sohasNext()returnsfalse) and so we can miss the following (i.e. latest) value. This means that the value after the last disconnect does not get plotted.This PR contains a fix for this where I have updated the
hasNext()method of the iterator to returntrueif we still need to process the most recent message (meaning thatnext()will be called one final time).